admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #13648 from carlocab/gcc-linux-audit

Browse Source 
formula_auditor: audit for Linux-only dependencies on GCC
This commit is contained in:
Mike McQuaid 2022-08-23 11:46:38 +01:00 committed by GitHub
commit c09b1a09ea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Library/Homebrew/formula_auditor.rb
View File

@ -335,6 +335,13 @@ module Homebrew
end end
return unless @core_tap return unless @core_tap
bad_gcc_dep = linux_only_gcc_dep?(formula) && (@strict || begin
fv = FormulaVersions.new(formula)
fv.formula_at_revision("origin/HEAD") { |prev_f| !linux_only_gcc_dep?(prev_f) }
end)
problem "Formulae in homebrew/core should not have a Linux-only dependency on GCC." if bad_gcc_dep
return if formula.tap&.audit_exception :versioned_dependencies_conflicts_allowlist, formula.name return if formula.tap&.audit_exception :versioned_dependencies_conflicts_allowlist, formula.name
# The number of conflicts on Linux is absurd. # The number of conflicts on Linux is absurd.
@ -855,5 +862,16 @@ module Homebrew
def head_only?(formula) def head_only?(formula)
formula.head && formula.stable.nil? formula.head && formula.stable.nil?
end end
def linux_only_gcc_dep?(formula)
# TODO: Make this check work when running on Linux and not simulating macOS too.
return false unless Homebrew::SimulateSystem.simulating_or_running_on_macos?
formula_hash = formula.to_hash_with_variations
deps = formula_hash["dependencies"]
linux_deps = formula_hash.dig("variations", :x86_64_linux, "dependencies")
deps.exclude?("gcc") && linux_deps&.include?("gcc")
end
end end
end end