From c0642e1b84ed17a9ed9e3ef503ed13c7230c165b Mon Sep 17 00:00:00 2001
From: Issy Long <me@issyl0.co.uk>
Date: Sat, 17 Oct 2020 21:47:58 +0100
Subject: [PATCH] vale-styles: Upgrade all checks to "error" level

- I added these all the way back in December 2019 in #6826, but only
  today realised that things have been failing unnoticeably because
  "warning" level exits with status code 0, so doesn't fail CI.
- Upgrading to "error" level will enable us to see the style errors in
  our docs and fix them faster.
- My editor also auto-formatted the YAML to have double quotes instead
  of single.
---
 docs/vale-styles/Homebrew/Abbreviations.yml | 2 +-
 docs/vale-styles/Homebrew/OxfordComma.yml   | 6 +++---
 docs/vale-styles/Homebrew/Pronouns.yml      | 4 ++--
 docs/vale-styles/Homebrew/Spacing.yml       | 6 +++---
 docs/vale-styles/Homebrew/Terms.yml         | 2 +-
 docs/vale-styles/Homebrew/Titles.yml        | 2 +-
 docs/vale-styles/Homebrew/Trademarks.yml    | 2 +-
 7 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/docs/vale-styles/Homebrew/Abbreviations.yml b/docs/vale-styles/Homebrew/Abbreviations.yml
index c26a146698..df562c44aa 100644
--- a/docs/vale-styles/Homebrew/Abbreviations.yml
+++ b/docs/vale-styles/Homebrew/Abbreviations.yml
@@ -2,7 +2,7 @@
 extends: substitution
 message: Use '%s'
 ignorecase: false
-link: 'https://github.com/Homebrew/brew/blob/HEAD/docs/Prose-Style-Guidelines.md#style-and-usage'
+link: "https://github.com/Homebrew/brew/blob/HEAD/docs/Prose-Style-Guidelines.md#style-and-usage"
 level: error
 nonword: true
 swap:
diff --git a/docs/vale-styles/Homebrew/OxfordComma.yml b/docs/vale-styles/Homebrew/OxfordComma.yml
index 4049ba328e..5cae610b34 100644
--- a/docs/vale-styles/Homebrew/OxfordComma.yml
+++ b/docs/vale-styles/Homebrew/OxfordComma.yml
@@ -1,8 +1,8 @@
 ---
 extends: existence
-message: 'No Oxford commas!'
-link: 'https://github.com/Homebrew/brew/blob/HEAD/docs/Prose-Style-Guidelines.md#typographical-conventions'
+message: "No Oxford commas!"
+link: "https://github.com/Homebrew/brew/blob/HEAD/docs/Prose-Style-Guidelines.md#typographical-conventions"
 scope: sentence
-level: warning
+level: error
 tokens:
   - '(?:[^,]+,){1,}\s\w+,\sand'
diff --git a/docs/vale-styles/Homebrew/Pronouns.yml b/docs/vale-styles/Homebrew/Pronouns.yml
index f980d584b2..263594fb3d 100644
--- a/docs/vale-styles/Homebrew/Pronouns.yml
+++ b/docs/vale-styles/Homebrew/Pronouns.yml
@@ -1,8 +1,8 @@
 ---
 extends: existence
 message: Avoid gender-specific language when not necessary.
-link: 'https://github.com/Homebrew/brew/blob/HEAD/docs/Prose-Style-Guidelines.md#personal-pronouns'
-level: warning
+link: "https://github.com/Homebrew/brew/blob/HEAD/docs/Prose-Style-Guidelines.md#personal-pronouns"
+level: error
 ignorecase: true
 tokens:
   - him
diff --git a/docs/vale-styles/Homebrew/Spacing.yml b/docs/vale-styles/Homebrew/Spacing.yml
index 0ee95cd5f8..ca752c5db3 100644
--- a/docs/vale-styles/Homebrew/Spacing.yml
+++ b/docs/vale-styles/Homebrew/Spacing.yml
@@ -1,9 +1,9 @@
 ---
 extends: existence
 message: "'%s' should have one space."
-link: 'https://github.com/Homebrew/brew/blob/HEAD/docs/Prose-Style-Guidelines.md#typographical-conventions'
+link: "https://github.com/Homebrew/brew/blob/HEAD/docs/Prose-Style-Guidelines.md#typographical-conventions"
 level: error
 nonword: true
 tokens:
-  - '[a-z][.?!][A-Z]'
-  - '[.?!] {2,}[A-Z]'
+  - "[a-z][.?!][A-Z]"
+  - "[.?!] {2,}[A-Z]"
diff --git a/docs/vale-styles/Homebrew/Terms.yml b/docs/vale-styles/Homebrew/Terms.yml
index 5803cdfc24..29ed33b171 100644
--- a/docs/vale-styles/Homebrew/Terms.yml
+++ b/docs/vale-styles/Homebrew/Terms.yml
@@ -1,7 +1,7 @@
 ---
 extends: substitution
 message: Use '%s' instead of '%s'.
-link: 'https://github.com/Homebrew/brew/blob/HEAD/docs/Prose-Style-Guidelines.md#terminology-words-and-word-styling'
+link: "https://github.com/Homebrew/brew/blob/HEAD/docs/Prose-Style-Guidelines.md#terminology-words-and-word-styling"
 level: error
 scope: $paragraph
 swap:
diff --git a/docs/vale-styles/Homebrew/Titles.yml b/docs/vale-styles/Homebrew/Titles.yml
index 3910edfdd4..2853a268f1 100644
--- a/docs/vale-styles/Homebrew/Titles.yml
+++ b/docs/vale-styles/Homebrew/Titles.yml
@@ -1,6 +1,6 @@
 extends: capitalization
 message: "'%s' should be in title case"
-level: warning
+level: error
 scope: heading.h1
 match: $title
 style: AP
diff --git a/docs/vale-styles/Homebrew/Trademarks.yml b/docs/vale-styles/Homebrew/Trademarks.yml
index 869ee35332..6f037aa3b2 100644
--- a/docs/vale-styles/Homebrew/Trademarks.yml
+++ b/docs/vale-styles/Homebrew/Trademarks.yml
@@ -1,7 +1,7 @@
 ---
 extends: existence
 message: 'No "TM", ™, SM, ©, ®, or other explicit indicators of rights ownership or trademarks'
-link: 'https://github.com/Homebrew/brew/blob/HEAD/docs/Prose-Style-Guidelines.md#typographical-conventions'
+link: "https://github.com/Homebrew/brew/blob/HEAD/docs/Prose-Style-Guidelines.md#typographical-conventions"
 level: error
 nonword: true
 tokens: