admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Expand #checkable_urls test coverage

Browse Source 
This expands tests for `#checkable_urls` to cover everything except
branches that shouldn't ever be reached.
This commit is contained in:
Sam Ford 2024-10-24 22:19:18 -04:00
parent d7b515bf73
commit bfdb84f676
No known key found for this signature in database
GPG Key ID: 7AF5CBEE1DD6F76D
1 changed files with 22 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
Library/Homebrew/test/livecheck/livecheck_spec.rb
View File

@ -36,6 +36,15 @@ RSpec.describe Homebrew::Livecheck do
end
end
let(:f_stable_url_only) do
stable_url_s = stable_url
formula("test_stable_url_only") do
desc "Test formula with only a stable URL"
url stable_url_s
end
end
let(:r) { f.resources.first }
let(:c) do
@ -56,6 +65,17 @@ RSpec.describe Homebrew::Livecheck do
RUBY
end
let(:c_no_checkable_urls) do
Cask::CaskLoader.load(+<<-RUBY)
cask "test_no_checkable_urls" do
version "1.2.3"
name "Test"
desc "Test cask with no checkable URLs"
end
RUBY
end
describe "::resolve_livecheck_reference" do
context "when a formula/cask has a livecheck block without formula/cask methods" do
it "returns [nil, []]" do
@ -134,15 +154,6 @@ RSpec.describe Homebrew::Livecheck do
end
end
let(:f_stable_url_only) do
stable_url_s = stable_url
formula("test_stable_url_only") do
desc "Test formula with only a stable URL"
url stable_url_s
end
end
let(:r_livecheck_url) { f_livecheck_url.resources.first }
let(:c_livecheck_url) do
@ -158,17 +169,6 @@ RSpec.describe Homebrew::Livecheck do
RUBY
end
let(:c_no_checkable_urls) do
Cask::CaskLoader.load(+<<-RUBY)
cask "test_no_checkable_urls" do
version "1.2.3"
name "Test"
desc "Test cask with no checkable URLs"
end
RUBY
end
it "returns a URL string when given a livecheck_url string for a formula" do
expect(livecheck.livecheck_url_to_string(livecheck_url, f_livecheck_url)).to eq(livecheck_url)
end
@ -235,6 +235,8 @@ RSpec.describe Homebrew::Livecheck do
expect(livecheck.checkable_urls(c)).to eq([cask_url, homepage_url])
expect(livecheck.checkable_urls(r)).to eq([resource_url])
expect(livecheck.checkable_urls(f_duplicate_urls)).to eq([stable_url, head_url])
expect(livecheck.checkable_urls(f_stable_url_only)).to eq([stable_url])
expect(livecheck.checkable_urls(c_no_checkable_urls)).to eq([])
end
end