admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: check the use of Dir[]

Browse Source 
Sometimes `Dir[]` is used with single files/directories unnecessarily.
This commit is contained in:
Mike McQuaid 2014-03-29 09:16:27 -05:00
parent 94f324d778
commit bf8ff2dcb7
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/cmd/audit.rb
View File

@ -525,6 +525,10 @@ class FormulaAuditor
if line =~ /depends_on ['"](.+)['"] (if.+|unless.+)$/ if line =~ /depends_on ['"](.+)['"] (if.+|unless.+)$/
audit_conditional_dep($1, $2, $&) audit_conditional_dep($1, $2, $&)
end end
if line =~ /(Dir\[("[^\*{},]+")\])/
problem "#{$1} is unnecessary; just use #{$2}"
end
end end
def audit_conditional_dep(dep, condition, line) def audit_conditional_dep(dep, condition, line)