Apply suggestions from code review

Co-Authored-By: MikeMcQuaid <mike@mikemcquaid.com>
This commit is contained in:
Mike McQuaid 2019-02-14 09:13:00 +00:00 committed by GitHub
parent 1b609ceeb3
commit bf873783d2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions

View File

@ -17,7 +17,7 @@ changes (e.g. version updates), triaging, fixing and debugging user-reported
issues, or reviewing user pull requests. You should also be making contributions issues, or reviewing user pull requests. You should also be making contributions
to Homebrew at least once per quarter. to Homebrew at least once per quarter.
You will should watch or regularly check Homebrew/brew and/or You should watch or regularly check Homebrew/brew and/or
Homebrew/homebrew-core. Let us know which (or both) so we can grant you commit Homebrew/homebrew-core. Let us know which (or both) so we can grant you commit
access appropriately. access appropriately.
@ -68,7 +68,7 @@ If they are interested in doing system administration work or Homebrew/brew rele
- Invite them to the [`homebrew-ops` private operations mailing list](https://lists.sfconservancy.org/mailman/admin/homebrew-ops/members/add). - Invite them to the [`homebrew-ops` private operations mailing list](https://lists.sfconservancy.org/mailman/admin/homebrew-ops/members/add).
- Invite them to the [`homebrew` private 1Password](https://homebrew.1password.com/people). - Invite them to the [`homebrew` private 1Password](https://homebrew.1password.com/people).
If they are elected to of the Homebrew's [Software Freedom Conservancy](https://sfconservancy.org) Project Leadership Committee: If they are elected to the Homebrew's [Software Freedom Conservancy](https://sfconservancy.org) Project Leadership Committee:
- Email their name, email and employer to homebrew@sfconservancy.org - Email their name, email and employer to homebrew@sfconservancy.org
- Make them [owners on the Homebrew GitHub organisation](https://github.com/orgs/Homebrew/people) - Make them [owners on the Homebrew GitHub organisation](https://github.com/orgs/Homebrew/people)

View File

@ -14,7 +14,7 @@ Homebrew release:
branch you can create a new Git tag. Ideally this should be signed with your branch you can create a new Git tag. Ideally this should be signed with your
GPG key. This can then be pushed to GitHub. GPG key. This can then be pushed to GitHub.
3. Use `brew release-notes --markdown $PREVIOUS_TAG` to generate the release 3. Use `brew release-notes --markdown $PREVIOUS_TAG` to generate the release
notes for the release. [Create a new release on GitHub](https://github.com/Homebrew/brew/releases) notes for the release. [Create a new release on GitHub](https://github.com/Homebrew/brew/releases/new)
based on the new tag. based on the new tag.
If this is a major or minor release (e.g. X.0.0 or X.Y.0) then there are a few more steps: If this is a major or minor release (e.g. X.0.0 or X.Y.0) then there are a few more steps: