Merge pull request #11509 from issyl0/cask-caveats-in-summary

cask/installer: Add Cask caveats to the end-of-operation summary

Library/Homebrew/cask/installer.rb

@@ -56,6 +56,8 @@ module Cask
       caveats = cask.caveats
       return if caveats.empty?
 
+      Homebrew.messages.record_caveats(cask.token, caveats)
+
       <<~EOS
         #{ohai_title "Caveats"}
         #{caveats}

Library/Homebrew/formula_installer.rb

@@ -769,7 +769,7 @@ class FormulaInstaller
 
     @show_summary_heading = true
     ohai "Caveats", caveats.to_s
-    Homebrew.messages.record_caveats(formula, caveats)
+    Homebrew.messages.record_caveats(formula.name, caveats)
   end
 
   sig { void }

Library/Homebrew/messages.rb

@@ -15,8 +15,8 @@ class Messages
     @install_times = []
   end
 
-  def record_caveats(f, caveats)
-    @caveats.push(formula: f.name, caveats: caveats)
+  def record_caveats(package, caveats)
+    @caveats.push(package: package, caveats: caveats)
   end
 
   def formula_installed(f, elapsed_time)
@@ -36,7 +36,7 @@ class Messages
 
     oh1 "Caveats"
     @caveats.each do |c|
-      ohai c[:formula], c[:caveats]
+      ohai c[:package], c[:caveats]
     end
   end