admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #10364 from SeekingMeaning/version-strict-typecheck

Browse Source 
os/mac/version: update method signatures
This commit is contained in:
Seeker 2021-01-22 10:32:55 -08:00 committed by GitHub
commit bf448def73
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Library/Homebrew/os/mac/version.rb
View File

@ -13,6 +13,7 @@ module OS
class Version < ::Version
extend T::Sig
sig { returns(Symbol) }
attr_reader :arch
SYMBOLS = {
@ -33,7 +34,7 @@ module OS
new(str, arch: arch)
end
sig { params(value: T.any(String, Symbol)).returns(T::Array[String]) }
sig { params(value: T.any(String, Symbol)).returns(T.any([], [String, T.nilable(String)])) }
def self.version_arch(value)
@all_archs_regex ||= begin
all_archs = Hardware::CPU::ALL_ARCHS.map(&:to_s)
@ -43,7 +44,7 @@ module OS
(-(?<suffix_arch>#{Regexp.union(all_archs)}))?$
/x
end
match = @all_archs_regex.match(value)
match = @all_archs_regex.match(value.to_s)
return [] unless match
version = match[:version]
@ -65,6 +66,7 @@ module OS
@comparison_cache = {}
end
sig { override.params(other: T.untyped).returns(T.nilable(Integer)) }
def <=>(other)
@comparison_cache.fetch(other) do
if SYMBOLS.key?(other) && to_sym == other