admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

tab: eliminate redundant 'Tab.create' arguments (#468)

Browse Source 
The `build` and `source_modified_time` arguments are always coming from
the matching attributes of the `Formula` instance. Thus query `formula`
for them instead of passing them individually.
This commit is contained in:
Martin Afanasjew 2016-07-08 01:14:34 +02:00 committed by GitHub
parent 86b1df96b9
commit bf40dd64df
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Library/Homebrew/build.rb
View File

@ -131,7 +131,8 @@ class Build
formula.install
stdlibs = detect_stdlibs(ENV.compiler)
Tab.create(formula, ENV.compiler, stdlibs.first, formula.build, formula.source_modified_time).write
tab = Tab.create(formula, ENV.compiler, stdlibs.first)
tab.write
# Find and link metafiles
formula.prefix.install_metafiles formula.buildpath

5
Library/Homebrew/tab.rb
View File

@ -15,7 +15,8 @@ class Tab < OpenStruct
CACHE.clear
end
def self.create(formula, compiler, stdlib, build, source_modified_time)
def self.create(formula, compiler, stdlib)
build = formula.build
attributes = {
"used_options" => build.used_options.as_flags,
"unused_options" => build.unused_options.as_flags,
@ -23,7 +24,7 @@ class Tab < OpenStruct
"built_as_bottle" => build.bottle?,
"poured_from_bottle" => false,
"time" => Time.now.to_i,
"source_modified_time" => source_modified_time.to_i,
"source_modified_time" => formula.source_modified_time.to_i,
"HEAD" => HOMEBREW_REPOSITORY.git_head,
"compiler" => compiler,
"stdlib" => stdlib,