From be9d91b2b80fdfe82720b2e2d3ceec378e33b371 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Wed, 28 Sep 2011 14:28:14 -0500 Subject: [PATCH] audit: match #{prefix}/libexec and prefix+'libexec' These were being picked up as just "#{prefix}/lib" and prefix+'lib' due to the eagerness of the regex. Reordering "lib" and "libexec" will take care of it; I couldn't think of a more clever solution. Signed-off-by: Jack Nagel --- Library/Homebrew/cmd/audit.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index 5f4796a6e5..cfa6879a02 100755 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -50,7 +50,7 @@ def audit_formula_text name, text end # Prefer formula path shortcuts in Pathname+ - if text =~ %r{\(\s*(prefix\s*\+\s*(['"])(bin|include|lib|libexec|sbin|share))} + if text =~ %r{\(\s*(prefix\s*\+\s*(['"])(bin|include|libexec|lib|sbin|share))} problems << " * \"(#{$1}...#{$2})\" should be \"(#{$3}+...)\"" end @@ -59,7 +59,7 @@ def audit_formula_text name, text end # Prefer formula path shortcuts in strings - if text =~ %r[(\#\{prefix\}/(bin|include|lib|libexec|sbin|share))] + if text =~ %r[(\#\{prefix\}/(bin|include|libexec|lib|sbin|share))] problems << " * \"#{$1}\" should be \"\#{#{$2}}\"" end