admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: suggest setting JAVA_HOME by depends_on :java

Browse Source 
Closes Homebrew/homebrew#37174.

Signed-off-by: Xu Cheng <xucheng@me.com>
This commit is contained in:
Xu Cheng 2015-02-25 14:13:36 +08:00
parent 747542352d
commit be15a514eb
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Library/Homebrew/cmd/audit.rb
View File

@ -198,6 +198,12 @@ class FormulaAuditor
end end
end end
def audit_java_home
if text =~ /JAVA_HOME/i && !formula.requirements.map(&:class).include?(JavaDependency)
problem "Use `depends_on :java` to set JAVA_HOME"
end
end
def audit_conflicts def audit_conflicts
formula.conflicts.each do |c| formula.conflicts.each do |c|
begin begin
@ -760,6 +766,7 @@ class FormulaAuditor
audit_specs audit_specs
audit_urls audit_urls
audit_deps audit_deps
audit_java_home
audit_conflicts audit_conflicts
audit_options audit_options
audit_patches audit_patches