admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Check empty? to avoid introducing nils

Browse Source 
[].last => nil
[].max => nil
This commit is contained in:
Jack Nagel 2015-05-26 19:49:43 -04:00
parent 13540f85ab
commit be0a1e7635
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/cmd/bottle.rb
View File

@ -125,14 +125,17 @@ module Homebrew
return ofail "Formula has no stable version: #{f.name}" return ofail "Formula has no stable version: #{f.name}"
end end
if ARGV.include? '--no-revision' bottle_revision = 0
bottle_revision = 0
else unless ARGV.include? "--no-revision"
ohai "Determining #{f.name} bottle revision..." ohai "Determining #{f.name} bottle revision..."
versions = FormulaVersions.new(f) versions = FormulaVersions.new(f)
bottle_revisions = versions.bottle_version_map("origin/master")[f.pkg_version] bottle_revisions = versions.bottle_version_map("origin/master")[f.pkg_version]
bottle_revisions.pop if bottle_revisions.last.to_i > 0
bottle_revision = bottle_revisions.any? ? bottle_revisions.max.to_i + 1 : 0 unless bottle_revisions.empty?
bottle_revisions.pop if bottle_revisions.last > 0
bottle_revision = bottle_revisions.max + 1
end
end end
filename = Bottle::Filename.create(f, bottle_tag, bottle_revision) filename = Bottle::Filename.create(f, bottle_tag, bottle_revision)