From bd5b41ed949ffcdf8cdb25d956bff0a4d6e9c5e2 Mon Sep 17 00:00:00 2001 From: Chongyu Zhu Date: Wed, 8 Aug 2018 12:19:36 +0800 Subject: [PATCH] Remove environment variables used by `hub`. As of #3870, this is no longer needed. --- Library/Homebrew/dev-cmd/bump-formula-pr.rb | 8 -------- bin/brew | 3 +-- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/Library/Homebrew/dev-cmd/bump-formula-pr.rb b/Library/Homebrew/dev-cmd/bump-formula-pr.rb index 1fd41737e3..3a8fb83ecf 100644 --- a/Library/Homebrew/dev-cmd/bump-formula-pr.rb +++ b/Library/Homebrew/dev-cmd/bump-formula-pr.rb @@ -78,14 +78,6 @@ module Homebrew # Use the user's browser, too. ENV["BROWSER"] = ENV["HOMEBREW_BROWSER"] - # Setup GitHub environment variables - %w[GITHUB_USER GITHUB_PASSWORD GITHUB_TOKEN].each do |env| - homebrew_env = ENV["HOMEBREW_#{env}"] - next unless homebrew_env - next if homebrew_env.empty? - ENV[env] = homebrew_env - end - formula = ARGV.formulae.first if formula diff --git a/bin/brew b/bin/brew index 6a3d133add..36da1ed52f 100755 --- a/bin/brew +++ b/bin/brew @@ -53,8 +53,7 @@ HOMEBREW_LIBRARY="$HOMEBREW_REPOSITORY/Library" # Whitelist and copy to HOMEBREW_* all variables previously mentioned in # manpage or used elsewhere by Homebrew. for VAR in AWS_ACCESS_KEY_ID AWS_SECRET_ACCESS_KEY BINTRAY_USER BINTRAY_KEY \ - BROWSER EDITOR GIT NO_COLOR PATH VISUAL \ - GITHUB_USER GITHUB_PASSWORD GITHUB_TOKEN + BROWSER EDITOR GIT NO_COLOR PATH VISUAL do # Skip if variable value is empty. [[ -z "${!VAR}" ]] && continue