From bd4f633673e12793d8ec18a45c352a2d4d1fc382 Mon Sep 17 00:00:00 2001 From: Martin Afanasjew Date: Mon, 4 Jan 2016 14:54:09 +0100 Subject: [PATCH] tests: use predefined commit author for robustness Some tests, that construct a Git repository for testing, will silently fail if the global Git user isn't properly set up. There are valid use cases for this, thus use a fixed commit author/committer for all tests instead of relying on the user's configuration. --- Library/Homebrew/cmd/tests.rb | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Library/Homebrew/cmd/tests.rb b/Library/Homebrew/cmd/tests.rb index 38f0875331..c5af2a72f3 100644 --- a/Library/Homebrew/cmd/tests.rb +++ b/Library/Homebrew/cmd/tests.rb @@ -5,6 +5,13 @@ module Homebrew ENV["HOMEBREW_TESTS_COVERAGE"] = "1" if ARGV.include? "--coverage" ENV["HOMEBREW_NO_COMPAT"] = "1" if ARGV.include? "--no-compat" + # Override author/committer as global settings might be invalid and thus + # will cause silent failure during the setup of dummy Git repositories. + %w[AUTHOR COMMITTER].each do |role| + ENV["GIT_#{role}_NAME"] = "brew tests" + ENV["GIT_#{role}_EMAIL"] = "brew-tests@localhost" + end + Homebrew.install_gem_setup_path! "bundler" unless quiet_system("bundle", "check") system "bundle", "install", "--path", "vendor/bundle"