admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #2269 from JCount/audit-conflicts-whitelist-bash-completion

Browse Source 
audit: whitelist bash-completion@* to use conflicts_with
This commit is contained in:
JCount 2017-03-06 12:05:43 -05:00 committed by GitHub
commit bd444dda43
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/dev-cmd/audit.rb
View File

@ -532,8 +532,10 @@ class FormulaAuditor
end end
end end
versioned_conflicts_whitelist = %w[node@ bash-completion@].freeze
return unless formula.conflicts.any? && formula.versioned_formula? return unless formula.conflicts.any? && formula.versioned_formula?
return if formula.name.start_with? "node@" return if formula.name.start_with?(*versioned_conflicts_whitelist)
problem <<-EOS problem <<-EOS
Versioned formulae should not use `conflicts_with`. Versioned formulae should not use `conflicts_with`.
Use `keg_only :versioned_formula` instead. Use `keg_only :versioned_formula` instead.