doctor: simplify handling of slow checks
Some (rather slow) checks should run after all other checks. Make that more obvious by removing them from the sorted list of all checks and then re-appending them to the resulting list. (Should be slightly more efficient than the `<array>.reverse.uniq.reverse` incantation, though that hardly matters given the cumulated run time of all the checks.) Slightly extend the list after verifying what the slowest checks are for various Homebrew installations (slowest check last). Closes Homebrew/homebrew#47753. Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
This commit is contained in:
parent
c9097b40f9
commit
bcedfe64e8
@ -12,9 +12,13 @@ module Homebrew
|
||||
checks.inject_dump_stats! if ARGV.switch? "D"
|
||||
|
||||
if ARGV.named.empty?
|
||||
methods = checks.all.sort
|
||||
methods << "check_for_linked_keg_only_brews" << "check_for_outdated_homebrew"
|
||||
methods = methods.reverse.uniq.reverse
|
||||
slow_checks = %w[
|
||||
check_for_broken_symlinks
|
||||
check_missing_deps
|
||||
check_for_outdated_homebrew
|
||||
check_for_linked_keg_only_brews
|
||||
]
|
||||
methods = (checks.all.sort - slow_checks) + slow_checks
|
||||
else
|
||||
methods = ARGV.named
|
||||
end
|
||||
|
Loading…
x
Reference in New Issue
Block a user