rubocop.yml: enable new rules.

This commit is contained in:
Mike McQuaid 2020-04-17 10:21:10 +01:00
parent e06e37291f
commit bc96428207
No known key found for this signature in database
GPG Key ID: 48A898132FD8EE70
2 changed files with 17 additions and 6 deletions

View File

@ -8,6 +8,19 @@ FormulaAudit:
FormulaAuditStrict: FormulaAuditStrict:
Enabled: true Enabled: true
# enable all pending rubocops
AllCops:
NewCops: enable
# don't allow cops to be disabled in formulae
Style/DisableCopsWithinSourceCodeDirective:
Enabled: true
Exclude:
# TODO: really long lines but hard to resolve (but would be nice to do).
- '**/Formula/libgraphqlparser.rb'
# TODO: false positive in RuboCop, see if it can be worked around/fixed.
- '**/Formula/rpm.rb'
# make our hashes consistent # make our hashes consistent
Layout/HashAlignment: Layout/HashAlignment:
EnforcedHashRocketStyle: table EnforcedHashRocketStyle: table
@ -46,12 +59,6 @@ Lint/AmbiguousRegexpLiteral:
Lint/ParenthesesAsGroupedExpression: Lint/ParenthesesAsGroupedExpression:
Enabled: false Enabled: false
# not enabled by default but nice to have
Lint/RaiseException:
Enabled: true
Lint/StructNewOverride:
Enabled: true
# most metrics don't make sense to apply for formulae/taps # most metrics don't make sense to apply for formulae/taps
Metrics/AbcSize: Metrics/AbcSize:
Enabled: false Enabled: false

View File

@ -8,6 +8,10 @@ AllCops:
Exclude: Exclude:
- '**/vendor/**/*' - '**/vendor/**/*'
# allow style to be disabled in non-formulae code
Style/DisableCopsWithinSourceCodeDirective:
Enabled: false
# Intentionally disabled as it doesn't fit with our code style. # Intentionally disabled as it doesn't fit with our code style.
RSpec/AnyInstance: RSpec/AnyInstance:
Enabled: false Enabled: false