admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #5723 from MikeMcQuaid/download-strategy-fix-content-encoding

Browse Source 
download_strategy: more robust filename content encoding handling.
This commit is contained in:
Mike McQuaid 2019-02-13 14:41:43 +00:00 committed by GitHub
commit bb6fe17a97
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/download_strategy.rb
View File

@ -371,12 +371,16 @@ class CurlDownloadStrategy < AbstractFileDownloadStrategy
parse_content_disposition = lambda do |line|
next unless content_disposition = content_disposition_parser.parse(line, true)
filename = nil
if filename_with_encoding = content_disposition.parameters["filename*"]
encoding, encoded_filename = filename_with_encoding.split("''", 2)
URI.decode_www_form_component(encoded_filename).encode(encoding)
else
content_disposition.filename
if encoding && encoded_filename
filename = URI.decode_www_form_component(encoded_filename).encode(encoding)
end
end
filename || content_disposition.filename
end
filenames = lines.map(&parse_content_disposition).compact