From bb588df05800b4a58f111bf028c6f7c73b70524c Mon Sep 17 00:00:00 2001 From: Baptiste Fontaine Date: Mon, 25 Jan 2016 11:48:13 +0100 Subject: [PATCH] tests: add pkgshare audit tests Closes Homebrew/homebrew#48435. Signed-off-by: Baptiste Fontaine --- Library/Homebrew/test/test_cmd_audit.rb | 26 +++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/Library/Homebrew/test/test_cmd_audit.rb b/Library/Homebrew/test/test_cmd_audit.rb index 16c0426edf..118dba544b 100644 --- a/Library/Homebrew/test/test_cmd_audit.rb +++ b/Library/Homebrew/test/test_cmd_audit.rb @@ -256,4 +256,30 @@ class FormulaAuditorTests < Homebrew::TestCase assert_equal ["AmazonWebServicesFormula is deprecated, use Formula instead"], fa.problems end + + def test_audit_line_pkgshare + fa = formula_auditor "foo", <<-EOS.undent, :strict => true + class Foo < Formula + url "http://example.com/foo-1.0.tgz" + end + EOS + fa.audit_line 'ohai "#{share}/foo"', 3 + assert_equal "Use \#{pkgshare} instead of \#{share}/foo", fa.problems.shift + + fa.audit_line 'ohai "#{share}/foo/bar"', 3 + assert_equal "Use \#{pkgshare} instead of \#{share}/foo", fa.problems.shift + + fa.audit_line 'ohai share/"foo"', 3 + assert_equal 'Use pkgshare instead of (share/"foo")', fa.problems.shift + + fa.audit_line 'ohai share/"foo/bar"', 3 + assert_equal 'Use pkgshare instead of (share/"foo")', fa.problems.shift + + fa.audit_line 'ohai "#{share}/foo-bar"', 3 + assert_equal [], fa.problems + fa.audit_line 'ohai share/"foo-bar"', 3 + assert_equal [], fa.problems + fa.audit_line 'ohai share/"bar"', 3 + assert_equal [], fa.problems + end end