From bb37aa28242c040b6402af3a9bcc918b9763c44f Mon Sep 17 00:00:00 2001 From: Baptiste Fontaine Date: Sun, 21 Feb 2016 13:15:12 +0100 Subject: [PATCH] go: warn about no-op stage_deps calls Closes Homebrew/homebrew#49389. Signed-off-by: Baptiste Fontaine --- Library/Homebrew/language/go.rb | 1 + Library/Homebrew/test/test_language_go.rb | 13 +++++++++++++ 2 files changed, 14 insertions(+) create mode 100644 Library/Homebrew/test/test_language_go.rb diff --git a/Library/Homebrew/language/go.rb b/Library/Homebrew/language/go.rb index c051aacc9a..08fa168039 100644 --- a/Library/Homebrew/language/go.rb +++ b/Library/Homebrew/language/go.rb @@ -7,6 +7,7 @@ module Language # The resource names should be the import name of the package, # e.g. `resource "github.com/foo/bar"` def self.stage_deps(resources, target) + opoo "tried to stage empty resources array" if resources.empty? resources.grep(Resource::Go) { |resource| resource.stage(target) } end end diff --git a/Library/Homebrew/test/test_language_go.rb b/Library/Homebrew/test/test_language_go.rb new file mode 100644 index 0000000000..0ad7f07fe8 --- /dev/null +++ b/Library/Homebrew/test/test_language_go.rb @@ -0,0 +1,13 @@ +# -*- coding: UTF-8 -*- + +require "testing_env" +require "language/go" + +class LanguageGoTests < Homebrew::TestCase + def test_stage_deps_empty + Language::Go.expects(:opoo).once + mktmpdir do |path| + shutup { Language::Go.stage_deps [], path } + end + end +end