From bac25a77bf12c4b5bbf67b611fad0c99785440e1 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Sat, 19 Apr 2014 21:39:40 -0500 Subject: [PATCH] Elaborate on why we should remove this code --- Library/Homebrew/os/mac/xcode.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/os/mac/xcode.rb b/Library/Homebrew/os/mac/xcode.rb index 2c215e0455..6102be841c 100644 --- a/Library/Homebrew/os/mac/xcode.rb +++ b/Library/Homebrew/os/mac/xcode.rb @@ -46,9 +46,12 @@ module OS if path != CLT::MAVERICKS_PKG_PATH and path.absolute? \ and File.executable? "#{path}/usr/bin/make" path - # TODO remove this branch when 10.10 is released elsif File.executable? "#{V4_BUNDLE_PATH}/Contents/Developer/usr/bin/make" - # fallback for broken Xcode 4.3 installs + # TODO Remove this branch when 10.10 is released + # This is a fallback for broken installations of Xcode 4.3+. Correct + # installations will be handled by the first branch. Pretending that + # broken installations are OK just leads to hard to diagnose problems + # later. Pathname.new("#{V4_BUNDLE_PATH}/Contents/Developer") elsif (path = bundle_path) path += "Contents/Developer"