admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

search: remove thread-unsafe Hash cache.

Browse Source 
Doesn't appear to affect the speed of `brew search`.

Fixes #415.
This commit is contained in:
Mike McQuaid 2016-08-12 21:29:49 +01:00
parent b3ea5c2595
commit b9efa6336e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/cmd/search.rb
View File

@ -126,7 +126,7 @@ module Homebrew
return [] return []
end end
@@remote_tap_formulae ||= Hash.new do |cache, key| remote_tap_formulae = Hash.new do |cache, key|
user, repo = key.split("/", 2) user, repo = key.split("/", 2)
tree = {} tree = {}
@ -148,7 +148,7 @@ module Homebrew
cache[key] = paths.map { |path| File.basename(path, ".rb") } cache[key] = paths.map { |path| File.basename(path, ".rb") }
end end
names = @@remote_tap_formulae["#{user}/#{repo}"] names = remote_tap_formulae["#{user}/#{repo}"]
user = user.downcase if user == "Homebrew" # special handling for the Homebrew organization user = user.downcase if user == "Homebrew" # special handling for the Homebrew organization
names.select { |name| rx === name }.map { |name| "#{user}/#{repo}/#{name}" } names.select { |name| rx === name }.map { |name| "#{user}/#{repo}/#{name}" }
rescue GitHub::HTTPNotFoundError => e rescue GitHub::HTTPNotFoundError => e