From b9efa6336eb914fce7cdca0fdbff4c75499a04b3 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Fri, 12 Aug 2016 21:29:49 +0100 Subject: [PATCH] search: remove thread-unsafe Hash cache. Doesn't appear to affect the speed of `brew search`. Fixes #415. --- Library/Homebrew/cmd/search.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cmd/search.rb b/Library/Homebrew/cmd/search.rb index d84bed2272..526c7220d6 100644 --- a/Library/Homebrew/cmd/search.rb +++ b/Library/Homebrew/cmd/search.rb @@ -126,7 +126,7 @@ module Homebrew return [] end - @@remote_tap_formulae ||= Hash.new do |cache, key| + remote_tap_formulae = Hash.new do |cache, key| user, repo = key.split("/", 2) tree = {} @@ -148,7 +148,7 @@ module Homebrew cache[key] = paths.map { |path| File.basename(path, ".rb") } end - names = @@remote_tap_formulae["#{user}/#{repo}"] + names = remote_tap_formulae["#{user}/#{repo}"] user = user.downcase if user == "Homebrew" # special handling for the Homebrew organization names.select { |name| rx === name }.map { |name| "#{user}/#{repo}/#{name}" } rescue GitHub::HTTPNotFoundError => e