brew-audit - check inreplace block var name

2010-09-08 09:07:59 -07:00 · 2010-09-08 09:07:59 -07:00 · b98d8366bc
commit b98d8366bc
parent bb3f9c4f3e
1 changed files with 5 additions and 0 deletions
--- a/Library/Contributions/examples/brew-audit.rb
+++ b/Library/Contributions/examples/brew-audit.rb
@ -29,6 +29,11 @@ def audit_formula_text text
    problems << " * Don't need 'FileUtils.' before #{$1}."
  end

+  # Check for long inreplace block vars
+  if text =~ /inreplace .* do \|(.{2,})\|/
+    problems << " * \"inreplace <filenames> do |s|\" is preferred over \"|#{$1}|\"."
+  end
+
  # Check for string interpolation of single values.
  if text =~ /(system|inreplace|gsub!|change_make_var!) .* ['"]#\{(\w+)\}['"]/
    problems << " * Don't need to interpolate \"#{$2}\" with #{$1}"