Merge pull request #6603 from MikeMcQuaid/tests-raise-deprecation-exceptions

Raise deprecation exceptions in tests

Library/Homebrew/test/cask/depends_on_spec.rb

@@ -47,14 +47,6 @@ describe "Satisfy Dependencies and Requirements", :cask do
       end
     end
 
-    context "given a string", :needs_compat do
-      let(:cask) { Cask::CaskLoader.load(cask_path("compat/with-depends-on-macos-string")) }
-
-      it "does not raise an error" do
-        expect { install }.not_to raise_error
-      end
-    end
-
     context "given a symbol" do
       let(:cask) { Cask::CaskLoader.load(cask_path("with-depends-on-macos-symbol")) }
 

Library/Homebrew/test/cask/dsl_spec.rb

@@ -335,14 +335,6 @@ describe Cask::DSL, :cask do
   end
 
   describe "depends_on macos" do
-    context "valid", :needs_compat do
-      let(:token) { "compat/with-depends-on-macos-string" }
-
-      it "allows depends_on macos to be specified" do
-        expect(cask.depends_on.macos).not_to be nil
-      end
-    end
-
     context "invalid depends_on macos value" do
       let(:token) { "invalid/invalid-depends-on-macos-bad-release" }
 

Library/Homebrew/test/formulary_spec.rb

@@ -246,12 +246,6 @@ describe Formulary do
       formula = described_class.find_with_priority(formula_name)
       expect(formula.path).to eq(core_path)
     end
-
-    it "prioritizes Formulae from pinned Taps" do
-      tap.pin
-      formula = described_class.find_with_priority(formula_name)
-      expect(formula.path).to eq(tap_path.realpath)
-    end
   end
 
   describe "::core_path" do

Library/Homebrew/test/spec_helper.rb

@@ -144,6 +144,7 @@ RSpec.configure do |config|
     end
 
     begin
+      Homebrew.raise_deprecation_exceptions = true
       Tap.clear_cache
       FormulaInstaller.clear_attempted