admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: check more GitHub URLs. (#256)

Browse Source 
GitHub’s code load and patch-diff URLs are the result of redirects and
make it harder to modify the URL to reach the original repository.
This commit is contained in:
Mike McQuaid 2016-05-19 07:56:11 +01:00
parent bc1d5ae4d4
commit b8e5ff431d
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Library/Homebrew/cmd/audit.rb
View File

@ -636,6 +636,13 @@ class FormulaAuditor
unless patch.url =~ /[a-fA-F0-9]{40}/ unless patch.url =~ /[a-fA-F0-9]{40}/
problem "GitHub/Gist patches should specify a revision:\n#{patch.url}" problem "GitHub/Gist patches should specify a revision:\n#{patch.url}"
end end
when %r{https?://patch-diff\.githubusercontent\.com/raw/(.+)/(.+)/pull/(.+)\.(?:diff|patch)}
problem <<-EOS.undent
use GitHub pull request URLs:
https://github.com/#{$1}/#{$2}/pulls/#{$3}.patch
Rather than patch-diff:
#{patch.url}
EOS
when %r{macports/trunk} when %r{macports/trunk}
problem "MacPorts patches should specify a revision instead of trunk:\n#{patch.url}" problem "MacPorts patches should specify a revision instead of trunk:\n#{patch.url}"
when %r{^http://trac\.macports\.org} when %r{^http://trac\.macports\.org}
@ -1235,6 +1242,17 @@ class ResourceAuditor
next unless u =~ %r{https://.*github.*/(archive|releases)/.*\.zip$} && u !~ %r{releases/download} next unless u =~ %r{https://.*github.*/(archive|releases)/.*\.zip$} && u !~ %r{releases/download}
problem "Use GitHub tarballs rather than zipballs (url is #{u})." problem "Use GitHub tarballs rather than zipballs (url is #{u})."
end end
# Don't use GitHub codeload URLs
urls.each do |u|
next unless u =~ %r{https?://codeload\.github\.com/(.+)/(.+)/(?:tar\.gz|zip)/(.+)}
problem <<-EOS.undent
use GitHub archive URLs:
https://github.com/#{$1}/#{$2}/archive/#{$3}.tar.gz
Rather than codeload:
#{u}
EOS
end
end end
def problem(text) def problem(text)