admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: fix redundant version check

Browse Source 
The == comparison was comparing the versions rather than directly
comparing the strings, which lead to false positives.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This commit is contained in:
Jack Nagel 2012-08-27 09:44:54 -05:00
parent dfd35db4d1
commit b8a62d98e1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/cmd/audit.rb
View File

@ -219,7 +219,7 @@ class FormulaAuditor
else else
version_text = s.version unless s.version.detected_from_url? version_text = s.version unless s.version.detected_from_url?
version_url = Version.parse(s.url) version_url = Version.parse(s.url)
if version_url == version_text if version_url.to_s == version_text.to_s
problem "#{spec} version #{version_text} is redundant with version scanned from URL" problem "#{spec} version #{version_text} is redundant with version scanned from URL"
end end
end end