From b87c23bb7e0bc4540ba32efc1c44c25a23d0e728 Mon Sep 17 00:00:00 2001 From: Michka Popoff Date: Thu, 28 Jan 2021 18:27:18 +0100 Subject: [PATCH] style: do not fail on sha256 lines with cellar information Fixes: 1-01-28T17:17:10.7152456Z [31m==>[0m [1m[31mFAILED[0m[0m 2021-01-28T17:17:10.7163169Z [36mFormula/dhall-json.rb[0m:14:12: [33mC[0m: sha256 should be 64 characters 2021-01-28T17:17:10.7175011Z sha256 cellar: :any_skip_relocation, big_sur: "a1e0cb4f7e4a7e0994b43ecd783240356631d36655cfbf59a903cc3f6a799242" 2021-01-28T17:17:10.7176620Z ^^^^^^ 2021-01-28T17:17:10.7178131Z [36mFormula/dhall-json.rb[0m:14:15: [33mC[0m: sha256 contains invalid characters 2021-01-28T17:17:10.7179886Z sha256 cellar: :any_skip_relocation, big_sur: "a1e0cb4f7e4a7e0994b43ecd783240356631d36655cfbf59a903cc3f6a799242" 2021-01-28T17:17:10.7181198Z ^^ 2021-01-28T17:17:10.7182390Z [36mFormula/dhall-json.rb[0m:15:12: [33mC[0m: sha256 should be 64 characters 2021-01-28T17:17:10.7183801Z sha256 cellar: :any_skip_relocation, catalina: "050f219d8050cf46a54487e0cad414374a5d2b4a6422d1e2e2c7a682149c3afb" 2021-01-28T17:17:10.7184956Z ^^^^^^ 2021-01-28T17:17:10.7186016Z [36mFormula/dhall-json.rb[0m:15:15: [33mC[0m: sha256 contains invalid characters 2021-01-28T17:17:10.7187458Z sha256 cellar: :any_skip_relocation, catalina: "050f219d8050cf46a54487e0cad414374a5d2b4a6422d1e2e2c7a682149c3afb" 2021-01-28T17:17:10.7188630Z ^^ --- Library/Homebrew/rubocops/checksum.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/rubocops/checksum.rb b/Library/Homebrew/rubocops/checksum.rb index e8035b8ee3..be355b7abc 100644 --- a/Library/Homebrew/rubocops/checksum.rb +++ b/Library/Homebrew/rubocops/checksum.rb @@ -32,7 +32,11 @@ module RuboCop return end - if string_content(checksum).size != 64 && regex_match_group(checksum, /^\w*$/) + checksum_string = string_content(checksum) + + return if checksum_string == "cellar" + + if checksum_string.size != 64 && regex_match_group(checksum, /^\w*$/) problem "sha256 should be 64 characters" end