From 5771c2f968ab1710517ba30f079038e40c6bbcc0 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Sat, 13 Jul 2024 17:55:44 -0400 Subject: [PATCH 1/2] attestation: only enable for developers outside CI Let's hold off on CI and devcmdrun for now. --- Library/Homebrew/attestation.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Library/Homebrew/attestation.rb b/Library/Homebrew/attestation.rb index 73567b8d8e..c4c77f6dc0 100644 --- a/Library/Homebrew/attestation.rb +++ b/Library/Homebrew/attestation.rb @@ -48,10 +48,10 @@ module Homebrew # TODO: allow this undocumented variable until this is rolled out more # widely and then we can remove or document it. return false if ENV.fetch("HOMEBREW_NO_VERIFY_ATTESTATIONS", false) - - Homebrew::EnvConfig.verify_attestations? || - Homebrew::EnvConfig.developer? || - Homebrew::Settings.read("devcmdrun") == "true" + return true if Homebrew::EnvConfig.verify_attestations? + return false if ENV.fetch("CI", false) + + Homebrew::EnvConfig.developer? end # Returns a path to a suitable `gh` executable for attestation verification. From 99b278b66b522054590ffb2d7aa56c938e9cc0b2 Mon Sep 17 00:00:00 2001 From: Patrick Linnane Date: Sat, 13 Jul 2024 14:58:07 -0700 Subject: [PATCH 2/2] `brew style --fix` Signed-off-by: Patrick Linnane --- Library/Homebrew/attestation.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/attestation.rb b/Library/Homebrew/attestation.rb index c4c77f6dc0..2055fd0f02 100644 --- a/Library/Homebrew/attestation.rb +++ b/Library/Homebrew/attestation.rb @@ -50,7 +50,7 @@ module Homebrew return false if ENV.fetch("HOMEBREW_NO_VERIFY_ATTESTATIONS", false) return true if Homebrew::EnvConfig.verify_attestations? return false if ENV.fetch("CI", false) - + Homebrew::EnvConfig.developer? end