admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #1930 from vitorgalvao/set-permissions-sudo

Browse Source 
cask: staged: no sudo in set_permissions
This commit is contained in:
Markus Reiter 2017-01-31 19:32:00 +01:00 committed by GitHub
commit b6f3399cb3
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/cask/lib/hbc/staged.rb
View File

@ -27,7 +27,7 @@ module Hbc
full_paths = remove_nonexistent(paths) full_paths = remove_nonexistent(paths)
return if full_paths.empty? return if full_paths.empty?
@command.run!("/bin/chmod", args: ["-R", "--", permissions_str] + full_paths, @command.run!("/bin/chmod", args: ["-R", "--", permissions_str] + full_paths,
sudo: true) sudo: false)
end end
def set_ownership(paths, user: current_user, group: "staff") def set_ownership(paths, user: current_user, group: "staff")

4
Library/Homebrew/cask/test/support/shared_examples/staged.rb
View File

@ -47,7 +47,7 @@ shared_examples_for Hbc::Staged do
staged.stubs(Pathname: fake_pathname) staged.stubs(Pathname: fake_pathname)
Hbc::FakeSystemCommand.expects_command( Hbc::FakeSystemCommand.expects_command(
["/usr/bin/sudo", "-E", "--", "/bin/chmod", "-R", "--", "777", fake_pathname] ["/bin/chmod", "-R", "--", "777", fake_pathname]
) )
staged.set_permissions(fake_pathname.to_s, "777") staged.set_permissions(fake_pathname.to_s, "777")
end end
@ -57,7 +57,7 @@ shared_examples_for Hbc::Staged do
staged.stubs(:Pathname).returns(fake_pathname) staged.stubs(:Pathname).returns(fake_pathname)
Hbc::FakeSystemCommand.expects_command( Hbc::FakeSystemCommand.expects_command(
["/usr/bin/sudo", "-E", "--", "/bin/chmod", "-R", "--", "777", fake_pathname, fake_pathname] ["/bin/chmod", "-R", "--", "777", fake_pathname, fake_pathname]
) )
staged.set_permissions([fake_pathname.to_s, fake_pathname.to_s], "777") staged.set_permissions([fake_pathname.to_s, fake_pathname.to_s], "777")
end end