admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #7172 from bayandin/full_index-for_patch-diff

Browse Source 
rubocops/patches: suggest url with full_index=1
This commit is contained in:
Mike McQuaid 2020-03-15 12:53:02 +00:00 committed by GitHub
commit b6d9b1aae6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/rubocops/patches.rb
View File

@ -57,7 +57,7 @@ module RuboCop
if match_obj = regex_match_group(patch, gh_patch_diff_pattern)
problem <<~EOS
use GitHub pull request URLs:
https://github.com/#{match_obj[1]}/#{match_obj[2]}/pull/#{match_obj[3]}.patch
https://github.com/#{match_obj[1]}/#{match_obj[2]}/pull/#{match_obj[3]}.patch?full_index=1
Rather than patch-diff:
#{patch_url}
EOS

4
Library/Homebrew/test/rubocops/patches_spec.rb
View File

@ -94,7 +94,7 @@ describe RuboCop::Cop::FormulaAudit::Patches do
[{ message:
<<~EOS,
use GitHub pull request URLs:
https://github.com/foo/foo-bar/pull/100.patch
https://github.com/foo/foo-bar/pull/100.patch?full_index=1
Rather than patch-diff:
https://patch-diff.githubusercontent.com/raw/foo/foo-bar/pull/100.patch
EOS
@ -231,7 +231,7 @@ describe RuboCop::Cop::FormulaAudit::Patches do
[{ message:
<<~EOS,
use GitHub pull request URLs:
https://github.com/foo/foo-bar/pull/100.patch
https://github.com/foo/foo-bar/pull/100.patch?full_index=1
Rather than patch-diff:
https://patch-diff.githubusercontent.com/raw/foo/foo-bar/pull/100.patch
EOS