admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: call puts once instead of problems.size + 2 times

Browse Source
This commit is contained in:
Jack Nagel 2014-10-17 00:35:51 -05:00
parent fb30041640
commit b6631b9a15
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Library/Homebrew/cmd/audit.rb
View File

@ -22,11 +22,9 @@ module Homebrew
fa.audit fa.audit
unless fa.problems.empty? unless fa.problems.empty?
puts "#{f.name}:"
fa.problems.each { |p| puts " * #{p}" }
puts
formula_count += 1 formula_count += 1
problem_count += fa.problems.size problem_count += fa.problems.size
puts "#{f.name}:", fa.problems.map { |p| " * #{p}" }, ""
end end
end end
@ -153,10 +151,7 @@ class FormulaAuditor
next if dep.build? or dep.run? next if dep.build? or dep.run?
problem %{#{dep} dependency should be "depends_on '#{dep}' => :build"} problem %{#{dep} dependency should be "depends_on '#{dep}' => :build"}
when "git", "ruby", "mercurial" when "git", "ruby", "mercurial"
problem <<-EOS.undent problem "Don't use #{dep} as a dependency. We allow non-Homebrew #{dep} installations."
Don't use #{dep} as a dependency. We allow non-Homebrew
#{dep} installations.
EOS
when 'gfortran' when 'gfortran'
problem "Use `depends_on :fortran` instead of `depends_on 'gfortran'`" problem "Use `depends_on :fortran` instead of `depends_on 'gfortran'`"
when 'open-mpi', 'mpich2' when 'open-mpi', 'mpich2'