admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Finalize methods that do not support overrides

Browse Source
This commit is contained in:
Douglas Eichelberger 2024-02-11 10:08:44 -08:00
parent c35546167d
commit b5d07dd7d6
1 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
Library/Homebrew/requirement.rb
View File

@ -61,8 +61,15 @@ class Requirement
s s
end end
# Overriding {#satisfied?} is unsupported. # Pass a block or boolean to the satisfy DSL method instead of overriding.
# Pass a block or boolean to the satisfy DSL method instead. sig(:final) {
params(
env: T.nilable(String),
cc: T.nilable(String),
build_bottle: T::Boolean,
bottle_arch: T.nilable(String),
).returns(T::Boolean)
}
def satisfied?(env: nil, cc: nil, build_bottle: false, bottle_arch: nil) def satisfied?(env: nil, cc: nil, build_bottle: false, bottle_arch: nil)
satisfy = self.class.satisfy satisfy = self.class.satisfy
return true unless satisfy return true unless satisfy
@ -76,8 +83,8 @@ class Requirement
true true
end end
# Overriding {#fatal?} is unsupported. # Pass a boolean to the fatal DSL method instead of overriding.
# Pass a boolean to the fatal DSL method instead. sig(:final) { returns(T::Boolean) }
def fatal? def fatal?
self.class.fatal || false self.class.fatal || false
end end
@ -92,8 +99,15 @@ class Requirement
parent parent
end end
# Overriding {#modify_build_environment} is unsupported. # Pass a block to the env DSL method instead of overriding.
# Pass a block to the env DSL method instead. sig(:final) {
params(
env: T.nilable(String),
cc: T.nilable(String),
build_bottle: T::Boolean,
bottle_arch: T.nilable(String),
).returns(T.untyped)
}
def modify_build_environment(env: nil, cc: nil, build_bottle: false, bottle_arch: nil) def modify_build_environment(env: nil, cc: nil, build_bottle: false, bottle_arch: nil)
satisfied?(env: env, cc: cc, build_bottle: build_bottle, bottle_arch: bottle_arch) satisfied?(env: env, cc: cc, build_bottle: build_bottle, bottle_arch: bottle_arch)
instance_eval(&env_proc) if env_proc instance_eval(&env_proc) if env_proc