From ed6d7ce9955a4ed630ff1c41ada994050ce8e0f9 Mon Sep 17 00:00:00 2001 From: Patrick Linnane Date: Wed, 28 Dec 2022 21:17:38 -0800 Subject: [PATCH 1/2] cask/audit: improve handling `nil` in sparkle --- Library/Homebrew/cask/audit.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cask/audit.rb b/Library/Homebrew/cask/audit.rb index bcf8d65f39..2a16181322 100644 --- a/Library/Homebrew/cask/audit.rb +++ b/Library/Homebrew/cask/audit.rb @@ -582,8 +582,9 @@ module Cask return if cask_min_os == min_os_string - min_os_symbol = cask_min_os&.to_sym.inspect || "no minimal OS version" - add_error "Upstream defined #{min_os_string.to_sym.inspect} as minimal OS version " \ + min_os_symbol = cask_min_os&.to_sym.inspect + min_os_symbol = "no minimum OS version" if min_os_symbol == "nil" + add_error "Upstream defined #{min_os_string.to_sym.inspect} as the minimum OS version " \ "and the cask defined #{min_os_symbol}" end From 7b6c8329b199141a2081fbe075bf692eb1a11a6e Mon Sep 17 00:00:00 2001 From: Patrick Linnane Date: Wed, 28 Dec 2022 21:31:02 -0800 Subject: [PATCH 2/2] Update Library/Homebrew/cask/audit.rb Co-authored-by: Rylan Polster --- Library/Homebrew/cask/audit.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cask/audit.rb b/Library/Homebrew/cask/audit.rb index 2a16181322..6322db89e8 100644 --- a/Library/Homebrew/cask/audit.rb +++ b/Library/Homebrew/cask/audit.rb @@ -582,8 +582,11 @@ module Cask return if cask_min_os == min_os_string - min_os_symbol = cask_min_os&.to_sym.inspect - min_os_symbol = "no minimum OS version" if min_os_symbol == "nil" + min_os_symbol = if cask_min_os.present? + cask_min_os.to_sym.inspect + else + "no minimum OS version" + end add_error "Upstream defined #{min_os_string.to_sym.inspect} as the minimum OS version " \ "and the cask defined #{min_os_symbol}" end