admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Clarify tap issues should not be reported to Homebrew.

Browse Source 
Instead, direct people to the actual tap.
This commit is contained in:
Mike McQuaid 2020-03-11 10:57:36 +00:00
parent 30c4383e86
commit b5165ed7e8
No known key found for this signature in database
GPG Key ID: 48A898132FD8EE70
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/brew.rb
View File

@ -160,7 +160,7 @@ rescue Exception => e # rubocop:disable Lint/RescueException
onoe e onoe e
if internal_cmd && defined?(OS::ISSUES_URL) && if internal_cmd && defined?(OS::ISSUES_URL) &&
!ENV["HOMEBREW_NO_AUTO_UPDATE"] !ENV["HOMEBREW_NO_AUTO_UPDATE"]
$stderr.puts "#{Tty.bold}Please report this bug:#{Tty.reset}" $stderr.puts "#{Tty.bold}Please report this issue:#{Tty.reset}"
$stderr.puts " #{Formatter.url(OS::ISSUES_URL)}" $stderr.puts " #{Formatter.url(OS::ISSUES_URL)}"
end end
$stderr.puts e.backtrace $stderr.puts e.backtrace

2
Library/Homebrew/formula_installer.rb
View File

@ -368,7 +368,7 @@ class FormulaInstaller
raise if ARGV.homebrew_developer? raise if ARGV.homebrew_developer?
$stderr.puts "Please report this to the #{formula.tap} tap!" $stderr.puts "Please report this issue to the #{formula.tap} tap (not Homebrew/brew or Homebrew/core)!"
false false
else # rubocop:disable Layout/ElseAlignment else # rubocop:disable Layout/ElseAlignment
f.linked_keg.exist? && f.opt_prefix.exist? f.linked_keg.exist? && f.opt_prefix.exist?

2
Library/Homebrew/utils.rb
View File

@ -167,7 +167,7 @@ module Kernel
next unless match = line.match(HOMEBREW_TAP_PATH_REGEX) next unless match = line.match(HOMEBREW_TAP_PATH_REGEX)
tap = Tap.fetch(match[:user], match[:repo]) tap = Tap.fetch(match[:user], match[:repo])
tap_message = +"\nPlease report this to the #{tap} tap" tap_message = +"\nPlease report this issue to the #{tap} tap (not Homebrew/brew or Homebrew/core)"
tap_message += ", or even better, submit a PR to fix it" if replacement tap_message += ", or even better, submit a PR to fix it" if replacement
tap_message << ":\n #{line.sub(/^(.*\:\d+)\:.*$/, '\1')}\n\n" tap_message << ":\n #{line.sub(/^(.*\:\d+)\:.*$/, '\1')}\n\n"
break break