utils/pypi: avoid creating new string objects

Co-authored-by: Markus Reiter <me@reitermark.us>
2020-11-29 13:54:13 -05:00 · 2020-11-29 13:54:13 -05:00 · b3b6ce77d8
commit b3b6ce77d8
parent 4bfb390577
1 changed files with 1 additions and 1 deletions
--- a/Library/Homebrew/utils/pypi.rb
+++ b/Library/Homebrew/utils/pypi.rb
@ -91,7 +91,7 @@ module PyPI

    sig { params(other: Package).returns(T::Boolean) }
    def same_package?(other)
-      @name.downcase.tr("_", "-") == other.name.downcase.tr("_", "-")
+      @name.tr("_", "-").casecmp(other.name.tr("_", "-")).zero?
    end

    # Compare only names so we can use .include? on a Package array