From 6874c79375176897b86215c410808fdacb034a51 Mon Sep 17 00:00:00 2001 From: Dawid Dziurla Date: Fri, 28 Feb 2020 12:47:03 +0100 Subject: [PATCH 1/3] node: add --unsafe-perm to std_args --- Library/Homebrew/language/node.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/Library/Homebrew/language/node.rb b/Library/Homebrew/language/node.rb index 4ae81f0bc0..d5785f9249 100644 --- a/Library/Homebrew/language/node.rb +++ b/Library/Homebrew/language/node.rb @@ -44,6 +44,7 @@ module Language %W[ -ddd --global + --unsafe-perm --build-from-source --#{npm_cache_config} --prefix=#{libexec} From 79a1500f2b7416cac9da55f02e8ba1d09e66404f Mon Sep 17 00:00:00 2001 From: Dawid Dziurla Date: Fri, 28 Feb 2020 12:56:38 +0100 Subject: [PATCH 2/3] node: add --unsafe-perm to std_args only if run as root --- Library/Homebrew/language/node.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/language/node.rb b/Library/Homebrew/language/node.rb index d5785f9249..44888eb3f9 100644 --- a/Library/Homebrew/language/node.rb +++ b/Library/Homebrew/language/node.rb @@ -41,15 +41,18 @@ module Language pack = pack_for_installation # npm install args for global style module format installed into libexec - %W[ + args = %W[ -ddd --global - --unsafe-perm --build-from-source --#{npm_cache_config} --prefix=#{libexec} #{Dir.pwd}/#{pack} ] + + args << "--unsafe-perm" if ENV["USER"] == "root" + + args end def self.local_npm_install_args From aac200a53db859ab1aa12284627eacc6f3e92cf0 Mon Sep 17 00:00:00 2001 From: Dawid Dziurla Date: Fri, 28 Feb 2020 13:36:29 +0100 Subject: [PATCH 3/3] node: detect root via Process.uid --- Library/Homebrew/language/node.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/language/node.rb b/Library/Homebrew/language/node.rb index 44888eb3f9..75d61f8a4e 100644 --- a/Library/Homebrew/language/node.rb +++ b/Library/Homebrew/language/node.rb @@ -50,7 +50,7 @@ module Language #{Dir.pwd}/#{pack} ] - args << "--unsafe-perm" if ENV["USER"] == "root" + args << "--unsafe-perm" if Process.uid.zero? args end