From b31c5cb13772ab97f41f215c6de1461ae4d53523 Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Sun, 3 Nov 2019 18:25:06 +0100 Subject: [PATCH] Allow `JAVA_HOME` in formulae depending on `openjdk`. --- Library/Homebrew/dev-cmd/audit.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index 119185a88f..3c4cf2f759 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -922,7 +922,9 @@ module Homebrew problem "Use separate make calls" if line.include?("make && make") - if line =~ /JAVA_HOME/i && !formula.requirements.map(&:class).include?(JavaRequirement) + if line =~ /JAVA_HOME/i && + [formula.name, *formula.deps.map(&:name)].none? { |name| name.match?(/^openjdk(@|$)/) } && + formula.requirements.none? { |req| req.is_a?(JavaRequirement) } problem "Use `depends_on :java` to set JAVA_HOME" end