admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

formulary: forbid cache paths

Browse Source
This commit is contained in:
Bo Anderson 2025-08-18 15:24:02 +01:00
parent b30d13c3ef
commit b1b28fb2f4
No known key found for this signature in database
2 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/formulary.rb
View File

@ -619,15 +619,9 @@ module Formulary
if Homebrew::EnvConfig.forbid_packages_from_paths?
path_realpath = path.realpath.to_s
path_string = path.to_s
allowed_paths = ["#{HOMEBREW_CELLAR}/", "#{HOMEBREW_LIBRARY}/Taps/"]
# Do not allow the cache if we explicitly set HOMEBREW_FORBID_PACKAGES_FROM_PATHS
# as the cache can contain arbitrary downloads. Allow it otherwise for convenience.
allowed_paths << "#{HOMEBREW_CACHE}/" unless ENV["HOMEBREW_FORBID_PACKAGES_FROM_PATHS"].present?
if (path_realpath.end_with?(".rb") || path_string.end_with?(".rb")) &&
!path_realpath.start_with?(*allowed_paths) &&
!path_string.start_with?(*allowed_paths)
!path_realpath.start_with?("#{HOMEBREW_CELLAR}/", "#{HOMEBREW_LIBRARY}/Taps/") &&
!path_string.start_with?("#{HOMEBREW_CELLAR}/", "#{HOMEBREW_LIBRARY}/Taps/")
if path_string.include?("./") || path_string.end_with?(".rb") || path_string.count("/") != 2
raise <<~WARNING
Homebrew requires formulae to be in a tap, rejecting:

5
Library/Homebrew/test/formulary_spec.rb
View File

@ -155,11 +155,6 @@ RSpec.describe Formulary do
cache_dir.rmdir if cache_dir.exist?
end
it "allows cache paths when paths are implicitly disabled" do
allow(Homebrew::EnvConfig).to receive(:forbid_packages_from_paths?).and_return(true)
expect(described_class.factory(cache_formula_path)).to be_a(Formula)
end
it "disallows cache paths when paths are explicitly disabled" do
ENV["HOMEBREW_FORBID_PACKAGES_FROM_PATHS"] = "1"
expect do