admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: make bind check more consistent.

Browse Source
This commit is contained in:
Mike McQuaid 2019-06-10 09:01:58 +01:00
parent 57fa2137b2
commit afc63578e0
No known key found for this signature in database
GPG Key ID: 48A898132FD8EE70
1 changed files with 18 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
Library/Homebrew/dev-cmd/audit.rb
View File

@ -702,31 +702,33 @@ module Homebrew
end end
stable = formula.stable stable = formula.stable
case stable&.url return unless stable
return unless stable.url
stable_version_string = stable.version.to_s
stable_url_version = Version.parse(stable.url)
_, stable_url_minor_version, = stable_url_version.to_s
.split(".", 3)
.map(&:to_i)
case stable.url
when /[\d\._-](alpha|beta|rc\d)/ when /[\d\._-](alpha|beta|rc\d)/
matched = Regexp.last_match(1) matched = Regexp.last_match(1)
version_prefix = stable.version.to_s.sub(/\d+$/, "") version_prefix = stable_version_string.sub(/\d+$/, "")
return if unstable_whitelist.include?([formula.name, version_prefix]) return if unstable_whitelist.include?([formula.name, version_prefix])
problem "Stable version URLs should not contain #{matched}" problem "Stable version URLs should not contain #{matched}"
when %r{download\.gnome\.org/sources}, %r{ftp\.gnome\.org/pub/GNOME/sources}i when %r{download\.gnome\.org/sources}, %r{ftp\.gnome\.org/pub/GNOME/sources}i
version_prefix = stable.version.to_s.split(".")[0..1].join(".") version_prefix = stable_version_string.split(".")[0..1].join(".")
return if gnome_devel_whitelist.include?([formula.name, version_prefix]) return if gnome_devel_whitelist.include?([formula.name, version_prefix])
return if stable_url_version < Version.create("1.0")
return if stable_url_minor_version.even?
version = Version.parse(stable.url) problem "#{stable.version} is a development release"
if version >= Version.create("1.0") when %r{isc.org/isc/bind\d*/}i
_, minor_version, = version.to_s.split(".", 3).map(&:to_i) return if stable_url_minor_version.even?
problem "#{stable.version} is a development release" if minor_version.odd?
end
end
case formula.name problem "#{stable.version} is a development release"
when /bind/
version = Version.parse(stable.url)
return if version.to_s.split(".").second.to_i.even?
problem "BIND releases with odd minor version numbers (9.13.x, 9.15.x, etc) are " \
"for testing, and can be unstable and are not suitable for general deployment. " \
end end
end end