brew audit: show line number for whitespace
Closes Homebrew/homebrew#24481. Closes Homebrew/homebrew#24490.
This commit is contained in:
parent
edef6508bd
commit
af4aff8c13
@ -332,7 +332,7 @@ class FormulaAuditor
|
|||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
def audit_line(line)
|
def audit_line(line, lineno)
|
||||||
if line =~ /<(Formula|AmazonWebServicesFormula|ScriptFileFormula|GithubGistFormula)/
|
if line =~ /<(Formula|AmazonWebServicesFormula|ScriptFileFormula|GithubGistFormula)/
|
||||||
problem "Use a space in class inheritance: class Foo < #{$1}"
|
problem "Use a space in class inheritance: class Foo < #{$1}"
|
||||||
end
|
end
|
||||||
@ -410,7 +410,7 @@ class FormulaAuditor
|
|||||||
|
|
||||||
# No trailing whitespace, please
|
# No trailing whitespace, please
|
||||||
if line =~ /[\t ]+$/
|
if line =~ /[\t ]+$/
|
||||||
problem "Trailing whitespace was found"
|
problem "#{lineno}: Trailing whitespace was found"
|
||||||
end
|
end
|
||||||
|
|
||||||
if line =~ /if\s+ARGV\.include\?\s+'--(HEAD|devel)'/
|
if line =~ /if\s+ARGV\.include\?\s+'--(HEAD|devel)'/
|
||||||
@ -568,7 +568,7 @@ class FormulaAuditor
|
|||||||
audit_conflicts
|
audit_conflicts
|
||||||
audit_patches
|
audit_patches
|
||||||
audit_text
|
audit_text
|
||||||
text.each_line { |line| audit_line(line) }
|
text.split("\n").each_with_index { |line, lineno| audit_line(line, lineno) }
|
||||||
audit_installed
|
audit_installed
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user