diff --git a/Library/Homebrew/dev-cmd/bump.rb b/Library/Homebrew/dev-cmd/bump.rb index c7e873babf..6cca9a9fd0 100644 --- a/Library/Homebrew/dev-cmd/bump.rb +++ b/Library/Homebrew/dev-cmd/bump.rb @@ -27,7 +27,7 @@ module Homebrew end def validate_and_format_packages(outdated_repology_packages) - ohai "Verifying outdated repology packages as Homebrew Formulae" + ohai "Verifying outdated repology packages as Homebrew formulae" packages = {} outdated_repology_packages.each do |_name, repositories| @@ -36,7 +36,7 @@ module Homebrew repo["repo"] == "homebrew" end - next if repology_homebrew_repo.empty? + next if repology_homebrew_repo.blank? latest_version = nil @@ -53,7 +53,7 @@ module Homebrew def format_package(package_name, latest_version) formula = get_formula_details(package_name) - return if formula.nil? + return if formula.blank? tap_full_name = formula.tap&.full_name current_version = current_formula_version(formula) @@ -91,7 +91,7 @@ module Homebrew def parse_livecheck_response(response) output = response.delete(" ").split(/:|==>/) - # eg: ["openclonk", "7.0", "8.1"] + # e.g. ["openclonk", "7.0", "8.1"] package_name, brew_version, latest_version = output { @@ -102,14 +102,14 @@ module Homebrew end def display(outdated_packages) - ohai "Outdated Formulae\n" + ohai "Outdated formulae\n" outdated_packages.each do |formula, package_details| ohai formula - ohai "Current formula version: #{package_details[:current_formula_version]}" - ohai "Latest repology version: #{package_details[:repology_latest_version]}" - ohai "Latest livecheck version: #{package_details[:livecheck_latest_version]}" - ohai "Open pull requests: #{package_details[:open_pull_requests]}" + puts "Current formula version: #{package_details[:current_formula_version]}" + puts "Latest repology version: #{package_details[:repology_latest_version]}" + puts "Latest livecheck version: #{package_details[:livecheck_latest_version]}" + puts "Open pull requests: #{package_details[:open_pull_requests]}" end end end diff --git a/Library/Homebrew/utils/repology.rb b/Library/Homebrew/utils/repology.rb index 07121bcee5..ba298038e7 100644 --- a/Library/Homebrew/utils/repology.rb +++ b/Library/Homebrew/utils/repology.rb @@ -8,7 +8,7 @@ module Repology MAX_PAGINATION = 15 def query_api(last_package_in_response = "") - last_package_in_response += "/" unless last_package_in_response.empty? + last_package_in_response += "/" unless last_package_in_response.blank? url = "https://repology.org/api/v1/projects/#{last_package_in_response}?inrepo=homebrew&outdated=1" @@ -25,7 +25,7 @@ module Repology page_no = 1 while response_size > 1 && page_no <= MAX_PAGINATION - odebug "Paginating Repology api page: #{page_no}" + odebug "Paginating Repology API page: #{page_no}" last_package_in_response = outdated_packages.keys[last_package_index] response = query_api(last_package_in_response) @@ -36,7 +36,7 @@ module Repology page_no += 1 end - ohai "#{outdated_packages.size} outdated packages identified" + ohai "#{outdated_packages.size} outdated #{"package".pluralize(outdated_packages.size)} identified" outdated_packages end