From ae952482a751b9c381bf0e95a26d444015308f20 Mon Sep 17 00:00:00 2001 From: Issy Long Date: Sat, 28 Dec 2024 22:34:40 +0000 Subject: [PATCH] env_config: Improve the deprecated envvar message MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before: ``` ❯ HOMEBREW_NO_ANALYTICS=0 brew formula-analytics --days-ago=2 Error: Calling HOMEBREW_NO_ANALYTICS=0 is deprecated! Use If you wish to enable HOMEBREW_NO_ANALYTICS, use HOMEBREW_NO_ANALYTICS=1 If you wish to disable HOMEBREW_NO_ANALYTICS, use HOMEBREW_NO_ANALYTICS= (an empty value). instead. ``` After: ``` ❯ HOMEBREW_NO_ANALYTICS=0 brew formula-analytics --days-ago=2 Error: Calling HOMEBREW_NO_ANALYTICS=0 is deprecated! Use HOMEBREW_NO_ANALYTICS=1 to enable and HOMEBREW_NO_ANALYTICS= (an empty value) to disable instead. ``` --- Library/Homebrew/env_config.rb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/env_config.rb b/Library/Homebrew/env_config.rb index e201d22398..d2441eb672 100644 --- a/Library/Homebrew/env_config.rb +++ b/Library/Homebrew/env_config.rb @@ -527,9 +527,8 @@ module Homebrew falsy_values = %w[false no off nil 0] if falsy_values.include?(env_value&.downcase) - odeprecated "#{env}=#{env_value}", <<~EOS - If you wish to enable #{env}, #{env}=1 - If you wish to disable #{env}, #{env}= + odeprecated "#{env}=#{env_value}", <<~EOS.chomp + #{env}=1 to enable and #{env}= (an empty value) to disable EOS end