From ad1213a7da8b8e991a0f316ab3f8e66dd4b68ca8 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Thu, 16 Feb 2023 17:51:42 +0000 Subject: [PATCH] utils/analytics: make on_request a proper boolean. Otherwise when it's `false` it's being turned into a `true` value. --- Library/Homebrew/utils/analytics.rb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/utils/analytics.rb b/Library/Homebrew/utils/analytics.rb index 5accb78790..79e9835511 100644 --- a/Library/Homebrew/utils/analytics.rb +++ b/Library/Homebrew/utils/analytics.rb @@ -76,8 +76,11 @@ module Utils additional_tags: T::Hash[Symbol, T.untyped]).void } def report_influx(measurement, package_and_options, on_request, additional_tags = {}) + # convert on_request to a boolean + on_request = on_request ? true : false + # Append general information to device information - tags = additional_tags.merge(package_and_options: package_and_options, on_request: !on_request.nil?) + tags = additional_tags.merge(package_and_options: package_and_options, on_request: on_request) .compact .map { |k, v| "#{k}=#{v.to_s.sub(" ", "\\ ")}" } # convert to key/value parameters .join(",")