admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Raise ArgumentError for argument errors

Browse Source
This commit is contained in:
Jack Nagel 2014-08-07 00:48:13 -05:00
parent 20452f3edc
commit acc1c35f35
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/software_spec.rb
View File

@ -78,8 +78,8 @@ class SoftwareSpec
def option name, description=nil def option name, description=nil
name = 'c++11' if name == :cxx11 name = 'c++11' if name == :cxx11
name = name.to_s if Symbol === name name = name.to_s if Symbol === name
raise "Option name is required." if name.empty? raise ArgumentError, "option name is required" if name.empty?
raise "Options should not start with dashes." if name[0, 1] == "-" raise ArgumentError, "options should not start with dashes" if name.start_with?("-")
build.add(name, description) build.add(name, description)
end end

4
Library/Homebrew/test/test_software_spec.rb
View File

@ -48,11 +48,11 @@ class SoftwareSpecTests < Homebrew::TestCase
end end
def test_option_raises_when_begins_with_dashes def test_option_raises_when_begins_with_dashes
assert_raises(RuntimeError) { @spec.option('--foo') } assert_raises(ArgumentError) { @spec.option("--foo") }
end end
def test_option_raises_when_name_empty def test_option_raises_when_name_empty
assert_raises(RuntimeError) { @spec.option('') } assert_raises(ArgumentError) { @spec.option("") }
end end
def test_option_accepts_symbols def test_option_accepts_symbols