From ac97c8545accb1f4d6ff271f097708bd695e888d Mon Sep 17 00:00:00 2001
From: Mike McQuaid <mike@mikemcquaid.com>
Date: Fri, 14 Feb 2020 12:18:55 +0000
Subject: [PATCH] cmd/upgrade, reinstall: don't install on dry-run.

Fixes #7033.
---
 Library/Homebrew/cmd/upgrade.rb | 2 ++
 Library/Homebrew/reinstall.rb   | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/Library/Homebrew/cmd/upgrade.rb b/Library/Homebrew/cmd/upgrade.rb
index 97b8fb1f3e..6ebfaf006b 100644
--- a/Library/Homebrew/cmd/upgrade.rb
+++ b/Library/Homebrew/cmd/upgrade.rb
@@ -326,6 +326,8 @@ module Homebrew
                                           .join(", ")
     end
 
+    return if args.dry_run?
+
     reinstallable_broken_dependents.each do |f|
       reinstall_formula(f, build_from_source: true)
     rescue FormulaInstallationAlreadyAttemptedError
diff --git a/Library/Homebrew/reinstall.rb b/Library/Homebrew/reinstall.rb
index 067d8b38e8..146d3170ef 100644
--- a/Library/Homebrew/reinstall.rb
+++ b/Library/Homebrew/reinstall.rb
@@ -8,6 +8,8 @@ module Homebrew
   module_function
 
   def reinstall_formula(f, build_from_source: false)
+    return if args.dry_run?
+
     if f.opt_prefix.directory?
       keg = Keg.new(f.opt_prefix.resolved_path)
       tab = Tab.for_keg(keg)