Merge pull request #13769 from reitermarkus/audit-codesign

Improve error message for failed signature check.
This commit is contained in:
Markus Reiter 2022-08-30 02:07:37 +02:00 committed by GitHub
commit ac94ca628d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -581,7 +581,19 @@ module Cask
next unless path.exist? next unless path.exist?
result = system_command("codesign", args: ["--verify", path], print_stderr: false) result = system_command("codesign", args: ["--verify", path], print_stderr: false)
add_warning result.merged_output unless result.success?
next if result.success?
message = "Signature verification failed:\n#{result.merged_output}\nmacOS on ARM requires applications " \
"to be signed. Please contact the upstream developer to let them know they should "
message += if result.stderr.include?("not signed at all")
"sign their app."
else
"fix the signature of their app."
end
add_warning message
end end
end end
end end