admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Add stderr output to exception.

Browse Source
This commit is contained in:
Markus Reiter 2018-06-11 03:18:47 +02:00
parent 6e519fc733
commit aaddce4743
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/style.rb
View File

@ -76,14 +76,14 @@ module Homebrew
system(cache_env, "rubocop", "_#{HOMEBREW_RUBOCOP_VERSION}_", *args) system(cache_env, "rubocop", "_#{HOMEBREW_RUBOCOP_VERSION}_", *args)
!$CHILD_STATUS.success? !$CHILD_STATUS.success?
when :json when :json
json, _, status = Open3.capture3(cache_env, "rubocop", "_#{HOMEBREW_RUBOCOP_VERSION}_", "--format", "json", *args) json, err, status = Open3.capture3(cache_env, "rubocop", "_#{HOMEBREW_RUBOCOP_VERSION}_", "--format", "json", *args)
# exit status of 1 just means violations were found; other numbers mean # exit status of 1 just means violations were found; other numbers mean
# execution errors. # execution errors.
# exitstatus can also be nil if RuboCop process crashes, e.g. due to # exitstatus can also be nil if RuboCop process crashes, e.g. due to
# native extension problems. # native extension problems.
# JSON needs to be at least 2 characters. # JSON needs to be at least 2 characters.
if !(0..1).cover?(status.exitstatus) || json.to_s.length < 2 if !(0..1).cover?(status.exitstatus) || json.to_s.length < 2
raise "Error running `rubocop --format json #{args.join " "}`" raise "Error running `rubocop --format json #{args.join " "}`\n#{err}"
end end
RubocopResults.new(JSON.parse(json)) RubocopResults.new(JSON.parse(json))
else else