From aad4ed7faad0abd7b2240b8a47a6ce3956bed19c Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Fri, 12 Jun 2015 20:14:04 -0400 Subject: [PATCH] Undocument return value of ENV.deparallelize It's not clear whether it returns MAKEFLAGS with or without -j, and neither is particularly useful behavior, given you can easily get the exact value by calling ENV["MAKEFLAGS"]. So let's not commit to this API. --- Library/Homebrew/extend/ENV/std.rb | 1 - Library/Homebrew/extend/ENV/super.rb | 1 - 2 files changed, 2 deletions(-) diff --git a/Library/Homebrew/extend/ENV/std.rb b/Library/Homebrew/extend/ENV/std.rb index 8992f8f840..bc165c667b 100644 --- a/Library/Homebrew/extend/ENV/std.rb +++ b/Library/Homebrew/extend/ENV/std.rb @@ -81,7 +81,6 @@ module Stdenv # Removes the MAKEFLAGS environment variable, causing make to use a single job. # This is useful for makefiles with race conditions. # When passed a block, MAKEFLAGS is removed only for the duration of the block and is restored after its completion. - # Returns the value of MAKEFLAGS. def deparallelize old = self['MAKEFLAGS'] remove 'MAKEFLAGS', /-j\d+/ diff --git a/Library/Homebrew/extend/ENV/super.rb b/Library/Homebrew/extend/ENV/super.rb index e21fc554ee..87ecc5de05 100644 --- a/Library/Homebrew/extend/ENV/super.rb +++ b/Library/Homebrew/extend/ENV/super.rb @@ -245,7 +245,6 @@ module Superenv # Removes the MAKEFLAGS environment variable, causing make to use a single job. # This is useful for makefiles with race conditions. # When passed a block, MAKEFLAGS is removed only for the duration of the block and is restored after its completion. - # Returns the value of MAKEFLAGS. def deparallelize old = delete('MAKEFLAGS') if block_given?