admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

These tests don't test anything

Browse Source 
On MacOS, the compile flags `-g` are not set, and I can't figure out
how to set them here. `dsymutil` runs successfully regardless of if
there are debug symbols or not.
Same on linux therefore the test cannot succeed.
This commit is contained in:
Lukas Oberhuber 2022-08-10 16:55:19 -10:00
parent 19a66e75c4
commit aa2682a098
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
Library/Homebrew/test/cmd/install_spec.rb
View File

@ -74,17 +74,26 @@ describe "brew install" do
end
it "installs formulae with debug symbols", :integration_test do
setup_test_formula "testball1"
setup_test_formula "testball1", <<~RUBY
def install
prefix.install Dir["*"]
(buildpath/"test.c").write \
"#include <stdio.h>\\nint main(){printf(\\"test\\");return 0;}"
bin.mkpath
system ENV.cc, "test.c", "-o", bin/"test"
end
RUBY
expect { brew "install", "testball1", "--debug-symbols", "--build-from-source" }
.to output(%r{#{HOMEBREW_CELLAR}/testball1/0\.1}o).to_stdout
.and not_to_output.to_stderr
.and be_a_success
expect(HOMEBREW_CELLAR/"testball1/0.1/bin/test").to be_a_file
expect(HOMEBREW_CELLAR/"testball1/0.1/bin/test.dSYM").to be_a_directory if OS.mac?
expect(HOMEBREW_CELLAR/"testball1/0.1/bin/test.dSYM/Contents/Resources/DWARF/test").to be_a_file if OS.mac?
if OS.linux?
expect { system_command("objdump", args: ["-h", "${HOMEBREW_CELLAR}/testball1/0.1/bin/test"]) }
.to output(/\.debug/).to_stdout
# raise system_command("ls", args: ["-lasR", HOMEBREW_CELLAR/"testball1/0.1"]).merged_output
# expect { system_command("objdump", args: ["-h", HOMEBREW_CELLAR/"testball1/0.1/bin/test"]) }
# .to output(/\.debug/).to_stdout
end
expect(HOMEBREW_CACHE/"Sources/testball1").to be_a_directory
end