admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

brew: tighten sudo checks

Browse Source 
`reinstall` can currently be executed under sudo and has every chunk of problems
running install under sudo does when `brew` isn't root owned.

Likewise with `postinstall` which we increasingly use to create directories and
move/install files elsewhere. Using sudo there both masks deeper issues and
makes uninstall troublesome.

Closes Homebrew/homebrew#45112.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
This commit is contained in:
Dominyk Tiller 2015-10-18 19:10:39 +01:00
parent b743cadd87
commit aa0a22147d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/brew.rb
View File

@ -97,7 +97,7 @@ begin
cmd = HOMEBREW_INTERNAL_COMMAND_ALIASES.fetch(cmd, cmd)
sudo_check = %w[ install link pin unpin upgrade ]
sudo_check = %w[ install reinstall postinstall link pin unpin upgrade ]
if sudo_check.include? cmd
if Process.uid.zero? && !File.stat(HOMEBREW_BREW_FILE).uid.zero?